chore(secretmanager): Updated test assertions

Author: durgesh-ninave-crest

secretmanager/test/regionalsecretmanagerTest.php

@@ -33,6 +33,7 @@
 use Google\Cloud\SecretManager\V1\CreateSecretRequest;
 use Google\Cloud\SecretManager\V1\DeleteSecretRequest;
 use Google\Cloud\SecretManager\V1\DisableSecretVersionRequest;
+use Google\Cloud\SecretManager\V1\GetSecretRequest;
 use Google\Cloud\SecretManager\V1\Secret;
 use Google\Cloud\SecretManager\V1\SecretPayload;
 use Google\Cloud\SecretManager\V1\SecretVersion;
@@ -166,6 +167,13 @@ private static function deleteSecret(string $name)
         }
     }
 
+    private static function getSecret(string $projectId, string $locationId, string $secretId): Secret
+    {
+        $name = self::$client->projectLocationSecretName($projectId, $locationId, $secretId);
+        $getSecretRequest = (new GetSecretRequest())->setName($name);
+        return self::$client->getSecret($getSecretRequest);
+    }
+
     private static function createTagKey(string $short_name): string
     {
         $parent = self::$client->projectName(self::$projectId);
@@ -605,6 +613,9 @@ public function testCreateSecretWithDelayedDestroyed()
         ]);
 
         $this->assertStringContainsString('Created secret', $output);
+
+        $secret = self::getSecret($name['project'], $name['location'], $name['secret']);
+        $this->assertEquals(self::$testDelayedDestroyTime, $secret->getVersionDestroyTtl()->getSeconds());
     }
 
     public function testDisableSecretDelayedDestroy()
@@ -618,6 +629,9 @@ public function testDisableSecretDelayedDestroy()
         ]);
 
         $this->assertStringContainsString('Updated secret', $output);
+
+        $secret = self::getSecret($name['project'], $name['location'], $name['secret']);
+        $this->assertNull($secret->getVersionDestroyTtl());
     }
 
     public function testUpdateSecretWithDelayedDestroyed()
@@ -632,5 +646,7 @@ public function testUpdateSecretWithDelayedDestroyed()
         ]);
 
         $this->assertStringContainsString('Updated secret', $output);
+        $secret = self::getSecret($name['project'], $name['location'], $name['secret']);
+        $this->assertEquals(self::$testDelayedDestroyTime, $secret->getVersionDestroyTtl()->getSeconds());
     }
 }

secretmanager/test/secretmanagerTest.php

@@ -33,6 +33,7 @@
 use Google\Cloud\SecretManager\V1\CreateSecretRequest;
 use Google\Cloud\SecretManager\V1\DeleteSecretRequest;
 use Google\Cloud\SecretManager\V1\DisableSecretVersionRequest;
+use Google\Cloud\SecretManager\V1\GetSecretRequest;
 use Google\Cloud\SecretManager\V1\Replication;
 use Google\Cloud\SecretManager\V1\Replication\Automatic;
 use Google\Cloud\SecretManager\V1\Secret;
@@ -171,6 +172,14 @@ private static function deleteSecret(string $name)
         }
     }
 
+    private static function getSecret(string $projectId, string $secretId): Secret
+    {
+        $name = self::$client->secretName($projectId, $secretId);
+        $getSecretRequest = (new GetSecretRequest())
+            ->setName($name);
+        return self::$client->getSecret($getSecretRequest);
+    }
+
     private static function createTagKey(string $short_name): string
     {
         $parent = self::$client->projectName(self::$projectId);
@@ -598,6 +607,9 @@ public function testCreateSecretWithDelayedDestroyed()
         ]);
 
         $this->assertStringContainsString('Created secret', $output);
+
+        $secret = self::getSecret($name['project'], $name['secret']);
+        $this->assertEquals(self::$testDelayedDestroyTime, $secret->getVersionDestroyTtl()->getSeconds());
     }
 
     public function testDisableSecretDelayedDestroy()
@@ -610,6 +622,9 @@ public function testDisableSecretDelayedDestroy()
         ]);
 
         $this->assertStringContainsString('Updated secret', $output);
+
+        $secret = self::getSecret($name['project'], $name['secret']);
+        $this->assertNull($secret->getVersionDestroyTtl());
     }
 
     public function testUpdateSecretWithDelayedDestroyed()
@@ -623,5 +638,8 @@ public function testUpdateSecretWithDelayedDestroyed()
         ]);
 
         $this->assertStringContainsString('Updated secret', $output);
+
+        $secret = self::getSecret($name['project'], $name['secret']);
+        $this->assertEquals(self::$testDelayedDestroyTime, $secret->getVersionDestroyTtl()->getSeconds());
     }
 }