Use the PHP default for PDO::ATTR_STRINGIFY_FETCHES

Author: JanJakes

tests/WP_PDO_MySQL_On_SQLite_PDO_API_Tests.php

@@ -8,6 +8,10 @@ class WP_PDO_MySQL_On_SQLite_PDO_API_Tests extends TestCase {
 
 	public function setUp(): void {
 		$this->driver = new WP_PDO_MySQL_On_SQLite( 'mysql-on-sqlite:path=:memory:;dbname=wp;' );
+
+		// Set "PDO::ATTR_STRINGIFY_FETCHES" to "false" explicitly, so the tests
+		// are consistent across PHP versions ("false" is the default from 8.1).
+		$this->driver->setAttribute( PDO::ATTR_STRINGIFY_FETCHES, false );
 	}
 
 	public function test_connection(): void {

wp-includes/sqlite-ast/class-wp-pdo-mysql-on-sqlite.php

@@ -451,6 +451,7 @@ class WP_PDO_MySQL_On_SQLite extends PDO {
 	 * @var array<int, mixed>
 	 */
 	private $pdo_attributes = array(
+		PDO::ATTR_STRINGIFY_FETCHES => PHP_VERSION_ID < 80100 ? true : false,
 	);
 
 	/**

wp-includes/sqlite-ast/class-wp-sqlite-connection.php

@@ -91,9 +91,6 @@ public function __construct( array $options ) {
 		}
 		$this->pdo->setAttribute( PDO::ATTR_TIMEOUT, $timeout );
 
-		// Return all values (except null) as strings.
-		$this->pdo->setAttribute( PDO::ATTR_STRINGIFY_FETCHES, true );
-
 		// Configure SQLite journal mode.
 		$journal_mode = $options['journal_mode'] ?? null;
 		if ( $journal_mode && in_array( $journal_mode, self::SQLITE_JOURNAL_MODES, true ) ) {

wp-includes/sqlite-ast/class-wp-sqlite-driver.php

@@ -74,6 +74,8 @@ public function __construct(
 		);
 		$this->main_db_name           = $database;
 		$this->client_info            = $this->mysql_on_sqlite_driver->client_info;
+
+		$connection->get_pdo()->setAttribute( PDO::ATTR_STRINGIFY_FETCHES, true );
 	}
 
 	/**