Skip to content

Commit 4ba8330

Browse files
committed
simplify business ID option
1 parent 84b5ee1 commit 4ba8330

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

tests/test_config.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -257,8 +257,7 @@ def test_uses_business_id_true(tmp_config_files, modify_umapi_config, cli_args,
257257
connector_options, _ = config_loader.get_umapi_options()
258258
UmapiConnector.create_conn = False
259259
umapi_connector = UmapiConnector('.primary', connector_options)
260-
assert umapi_connector.ignore_identity_type
261-
assert umapi_connector.remove_trustee_users
260+
assert umapi_connector.uses_business_id
262261

263262

264263
def test_uses_business_id_false(tmp_config_files, modify_umapi_config, cli_args, private_key):
@@ -270,8 +269,7 @@ def test_uses_business_id_false(tmp_config_files, modify_umapi_config, cli_args,
270269
connector_options, _ = config_loader.get_umapi_options()
271270
UmapiConnector.create_conn = False
272271
umapi_connector = UmapiConnector('.primary', connector_options)
273-
assert not umapi_connector.ignore_identity_type
274-
assert not umapi_connector.remove_trustee_users
272+
assert not umapi_connector.uses_business_id
275273

276274

277275
def test_uses_business_id_unspecified(tmp_config_files, modify_umapi_config, cli_args, private_key):
@@ -282,5 +280,4 @@ def test_uses_business_id_unspecified(tmp_config_files, modify_umapi_config, cli
282280
connector_options, _ = config_loader.get_umapi_options()
283281
UmapiConnector.create_conn = False
284282
umapi_connector = UmapiConnector('.primary', connector_options)
285-
assert not umapi_connector.ignore_identity_type
286-
assert not umapi_connector.remove_trustee_users
283+
assert not umapi_connector.uses_business_id

user_sync/connector/umapi.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,7 @@ def __init__(self, name, caller_options):
5656
self.trusted = caller_config.get_bool('trusted', True)
5757
if self.trusted is None:
5858
self.trusted = False
59-
uses_business_id = caller_config.get_bool('uses_business_id', True)
60-
self.ignore_identity_type = False
61-
self.remove_trustee_users = False
62-
if uses_business_id is True:
63-
self.ignore_identity_type = True
64-
self.remove_trustee_users = True
59+
self.uses_business_id = caller_config.get_bool('uses_business_id', True)
6560
builder = user_sync.config.OptionsBuilder(caller_config)
6661
builder.set_string_value('logger_name', self.name)
6762
builder.set_bool_value('test_mode', False)

0 commit comments

Comments
 (0)