Skip to content

Commit fe073bf

Browse files
committed
update summary log
1 parent ae60e59 commit fe073bf

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

user_sync/engine/sign.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,11 +121,8 @@ def log_action_summary(self):
121121
'Number of Sign users read': self.total_sign_user_count,
122122
'Number of Sign users not in directory (sign-only)': self.total_sign_only_user_count,
123123
'Number of Sign users updated': len(self.sign_users_group_updates | self.sign_users_role_updates),
124-
'Number of users with matched groups unchanged': len(self.sign_users_matched_groups),
125-
'Number of users with admin roles unchanged': len(self.sign_admins_matched),
126124
'Number of users with groups updated': len(self.sign_users_group_updates),
127125
'Number of users admin roles updated': len(self.sign_users_role_updates),
128-
'Number of users matched with no updates': len(self.sign_users_matched_no_updates),
129126
'Number of Sign users created': len(self.sign_users_created),
130127
'Number of Sign users deactivated': len(self.sign_users_deactivated),
131128
}
@@ -200,6 +197,7 @@ def update_sign_users(self, directory_users, sign_connector: SignConnector, org_
200197
self.logger.info(f"Removing account admin status from f{sign_user.email}")
201198
user_data = DetailedUserInfo(**sign_user.__dict__)
202199
user_data.isAccountAdmin = is_admin
200+
self.sign_users_role_updates.add(sign_user.email)
203201
users_update_list.append(user_data)
204202
# manage primary group asssignment
205203
current_group: UserGroupInfo = self.sign_user_primary_groups[org_name][sign_user.id]
@@ -220,13 +218,15 @@ def update_sign_users(self, directory_users, sign_connector: SignConnector, org_
220218
if current_group.name.lower() != assignment_group.lower():
221219
assignment_group_info: GroupInfo = self.sign_groups[org_name][assignment_group.lower()]
222220
self.logger.info(f"Assigning primary group '{assignment_group}' to user {sign_user.email}")
223-
group_to_assign.id=assignment_group_info.groupId
224-
group_to_assign.name=assignment_group_info.groupName
221+
group_to_assign.id = assignment_group_info.groupId
222+
group_to_assign.name = assignment_group_info.groupName
223+
self.sign_users_group_updates.add(sign_user.email)
225224
updated_group_info=True
226225

227226
if is_group_admin != should_be_group_admin:
228227
self.logger.info(f"Changing group Admin role for user '{sign_user.email}', status? {should_be_group_admin}")
229228
group_to_assign.isGroupAdmin = should_be_group_admin
229+
self.sign_users_role_updates.add(sign_user.email)
230230
updated_group_info=True
231231

232232
if updated_group_info:
@@ -444,6 +444,7 @@ def handle_sign_only_users(self, sign_connector: SignConnector, org_name: str):
444444
comment='Deactivated by User Sync Tool'
445445
)
446446
sign_connector.update_user_state(user.id, state)
447+
self.sign_users_deactivated.add(user.email)
447448
self.logger.info(f"{self.org_string(org_name)}Deactivated sign user '{user.email}'")
448449
except ClientException as e:
449450
self.logger.error(format(e))

0 commit comments

Comments
 (0)