From 7cfdc24783f30163270c2ad1c834780c6587582c Mon Sep 17 00:00:00 2001 From: aRtoo Date: Tue, 20 Nov 2018 15:00:00 -0800 Subject: [PATCH 1/2] somewhat improve urlify --- chapter01/1.3 - URLify/urlify.js | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/chapter01/1.3 - URLify/urlify.js b/chapter01/1.3 - URLify/urlify.js index 7e993d5..8e3d190 100644 --- a/chapter01/1.3 - URLify/urlify.js +++ b/chapter01/1.3 - URLify/urlify.js @@ -13,7 +13,7 @@ var urlify = function(str, length) { strArr[pointer+1] = '2'; strArr[pointer+2] = '0'; console.log(strArr, strArr.length); - } + } pointer++; } // if character is a space, move remainder chars by two @@ -21,4 +21,18 @@ var urlify = function(str, length) { return strArr.join(''); }; -console.log(urlify('Mr John Smith ', 13), 'Mr%20John%20Smith'); +function URLify2(str, len) { + let i = 0, newStr = ''; + + while(i Date: Tue, 20 Nov 2018 15:04:50 -0800 Subject: [PATCH 2/2] added comments --- chapter01/1.3 - URLify/urlify.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/chapter01/1.3 - URLify/urlify.js b/chapter01/1.3 - URLify/urlify.js index 8e3d190..6923ed0 100644 --- a/chapter01/1.3 - URLify/urlify.js +++ b/chapter01/1.3 - URLify/urlify.js @@ -21,18 +21,26 @@ var urlify = function(str, length) { return strArr.join(''); }; +// takes 2 arguments a string and length of true strin function URLify2(str, len) { + // setup i to be 0, use to iterate + // newStr will be use to concat character from str let i = 0, newStr = ''; + // while i is less than the len while(i