Skip to content

Commit 4c35b6e

Browse files
committed
compiles with checkstyle + splotless - tets fail - no licences
Signed-off-by: davidradl <[email protected]>
1 parent 5c36bc0 commit 4c35b6e

File tree

78 files changed

+678
-489
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

78 files changed

+678
-489
lines changed

src/main/java/org/apache/flink/connectors/http/HttpPostRequestCallbackFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
*
1414
* <pre>resources/META-INF/services/org.apache.flink.table.factories.Factory</pre>
1515
*
16-
* file and then referenced by their identifiers in:
16+
* <p>file and then referenced by their identifiers in:
1717
*
1818
* <ul>
1919
* <li>The HttpSink DDL property field <i>gid.connector.http.sink.request-callback</i> for HTTP

src/main/java/org/apache/flink/connectors/http/HttpSinkBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ public HttpSinkBuilder<InputT> setProperty(String propertyName, String propertyV
164164
}
165165

166166
/**
167-
* Add properties to Http Sink configuration
167+
* Add properties to Http Sink configuration.
168168
*
169169
* @param properties properties to add
170170
* @return {@link HttpSinkBuilder} itself

src/main/java/org/apache/flink/connectors/http/LookupQueryCreatorFactory.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@
1414
*
1515
* <p>Custom implementations of {@link LookupQueryCreatorFactory} can be registered along other
1616
* factories in
17+
*
1718
* <pre>resources/META-INF.services/org.apache.flink.table.factories.Factory</pre>
18-
* file and then referenced by their identifiers in the HttpLookupSource DDL property field
19+
*
20+
* <p>file and then referenced by their identifiers in the HttpLookupSource DDL property field
1921
* <i>gid.connector.http.source.lookup.query-creator</i>.
2022
*
2123
* <p>The following example shows the minimum Table API example to create a {@link

src/main/java/org/apache/flink/connectors/http/internal/SinkHttpClientResponse.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
package org.apache.flink.connectors.http.internal;
22

3+
import org.apache.flink.connectors.http.internal.sink.HttpSinkRequestEntry;
4+
import org.apache.flink.connectors.http.internal.sink.httpclient.HttpRequest;
5+
36
import lombok.Data;
47
import lombok.NonNull;
58
import lombok.ToString;
6-
import org.apache.flink.connectors.http.internal.sink.HttpSinkRequestEntry;
7-
import org.apache.flink.connectors.http.internal.sink.httpclient.HttpRequest;
89

910
import java.util.List;
1011

src/main/java/org/apache/flink/connectors/http/internal/sink/HttpSinkRequestEntry.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,7 @@ public final class HttpSinkRequestEntry implements Serializable {
4242
/** Body of the request, encoded as byte array. */
4343
public final byte[] element;
4444

45-
/**
46-
* @return the size of the {@link HttpSinkRequestEntry#element}
47-
*/
45+
/** @return the size of the {@link HttpSinkRequestEntry#element} */
4846
public long getSizeInBytes() {
4947
return element.length;
5048
}

src/main/java/org/apache/flink/connectors/http/internal/table/lookup/BodyBasedRequestFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public BodyBasedRequestFactory(
3535

3636
/**
3737
* Method for preparing {@link HttpRequest.Builder} for REST request that sends their parameters
38-
* in request body, for example PUT or POST methods
38+
* in request body, for example PUT or POST methods.
3939
*
4040
* @param lookupQueryInfo lookup query info used for request body.
4141
* @return {@link HttpRequest.Builder} for given lookupQuery.

src/main/java/org/apache/flink/connectors/http/internal/table/lookup/GetRequestFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@ protected Logger getLogger() {
3232

3333
/**
3434
* Method for preparing {@link HttpRequest.Builder} for REST GET request. Where lookupQueryInfo
35-
* is used as query parameters for GET requests, for example:
35+
* is used as query parameters for GET requests. for example:
3636
*
3737
* <pre>
3838
* http:localhost:8080/service?id=1
3939
* </pre>
4040
*
41-
* or as payload for body-based requests with optional parameters, for example:
41+
* <p>or as payload for body-based requests with optional parameters, for example:
4242
*
4343
* <pre>
4444
* http:localhost:8080/service?id=1

src/main/java/org/apache/flink/connectors/http/internal/table/lookup/HttpLookupTableSourceFactory.java

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,28 @@
2929
import java.util.function.Predicate;
3030
import java.util.stream.Collectors;
3131

32-
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.*;
32+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.ASYNC_POLLING;
33+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.LOOKUP_METHOD;
34+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.LOOKUP_REQUEST_FORMAT;
35+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.REQUEST_CALLBACK_IDENTIFIER;
36+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_CONNECTION_TIMEOUT;
37+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_HTTP_IGNORED_RESPONSE_CODES;
38+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_HTTP_RETRY_CODES;
39+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_HTTP_SUCCESS_CODES;
40+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_OIDC_AUTH_TOKEN_ENDPOINT_URL;
41+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_OIDC_AUTH_TOKEN_EXPIRY_REDUCTION;
42+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_OIDC_AUTH_TOKEN_REQUEST;
43+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_PROXY_HOST;
44+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_PROXY_PASSWORD;
45+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_PROXY_PORT;
46+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_PROXY_USERNAME;
47+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_RETRY_EXPONENTIAL_DELAY_INITIAL_BACKOFF;
48+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_RETRY_EXPONENTIAL_DELAY_MAX_BACKOFF;
49+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_RETRY_EXPONENTIAL_DELAY_MULTIPLIER;
50+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_RETRY_FIXED_DELAY_DELAY;
51+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.SOURCE_LOOKUP_RETRY_STRATEGY;
52+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.URL;
53+
import static org.apache.flink.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.URL_ARGS;
3354
import static org.apache.flink.table.api.DataTypes.FIELD;
3455
import static org.apache.flink.table.types.utils.DataTypeUtils.removeTimeAttribute;
3556

src/main/java/org/apache/flink/connectors/http/internal/table/lookup/LookupQueryInfo.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
package org.apache.flink.connectors.http.internal.table.lookup;
22

3-
import lombok.Getter;
4-
import lombok.ToString;
53
import org.apache.flink.connectors.http.internal.utils.uri.NameValuePair;
64
import org.apache.flink.connectors.http.internal.utils.uri.URLEncodedUtils;
75

6+
import lombok.Getter;
7+
import lombok.ToString;
8+
89
import java.io.Serializable;
910
import java.nio.charset.StandardCharsets;
1011
import java.util.Collections;

src/main/java/org/apache/flink/connectors/http/internal/table/lookup/LookupRow.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
package org.apache.flink.connectors.http.internal.table.lookup;
22

3-
import lombok.Getter;
4-
import lombok.Setter;
5-
import lombok.ToString;
63
import org.apache.flink.annotation.VisibleForTesting;
74
import org.apache.flink.connectors.http.LookupArg;
85
import org.apache.flink.table.data.RowData;
96
import org.apache.flink.table.types.DataType;
107

8+
import lombok.Getter;
9+
import lombok.Setter;
10+
import lombok.ToString;
11+
1112
import java.io.Serializable;
1213
import java.util.Collection;
1314
import java.util.LinkedList;

0 commit comments

Comments
 (0)