[PredicateInfo] Infer operand bound from mul nuw square predicates

A mul nuw X, X used in an assume/branch condition cannot overflow (or
the condition would be poison, which is UB for assumes and control
flow), which implies:

  X < 2^ceil(bitwidth(X)/2) (e.g., i16: X < 256).

Author: ken-matsui

llvm/lib/Transforms/Utils/PredicateInfo.cpp

@@ -345,6 +345,14 @@ void collectCmpOps(CmpInst *Comparison, SmallVectorImpl<Value *> &CmpOperands) {
 
   CmpOperands.push_back(Op0);
   CmpOperands.push_back(Op1);
+
+  auto AddSquareOp = [&CmpOperands](Value *V) {
+    Value *SquareOp;
+    if (match(V, m_NUWMul(m_Value(SquareOp), m_Deferred(SquareOp))))
+      CmpOperands.push_back(SquareOp);
+  };
+  AddSquareOp(Op0);
+  AddSquareOp(Op1);
 }
 
 // Add Op, PB to the list of value infos for Op, and mark Op to be renamed.
@@ -735,6 +743,25 @@ std::optional<PredicateConstraint> PredicateBase::getConstraint() const {
       return std::nullopt;
     }
 
+    // A `mul nuw RenamedOp, RenamedOp` used by the condition cannot overflow
+    // (or the condition would be poison, which is UB for assumes and control
+    // flow), which implies `RenamedOp < 2^ceil(bitwidth(RenamedOp)/2)`
+    // (e.g., i16: `RenamedOp < 256`).
+    auto IsNuwSquareOfRenamedOp = [this](Value *V) {
+      return match(V, m_NUWMul(m_Specific(RenamedOp), m_Specific(RenamedOp)));
+    };
+    if (RenamedOp->getType()->isIntegerTy() &&
+        (IsNuwSquareOfRenamedOp(Cmp->getOperand(0)) ||
+         IsNuwSquareOfRenamedOp(Cmp->getOperand(1)))) {
+      unsigned BitWidth = RenamedOp->getType()->getScalarSizeInBits();
+      unsigned LimitBits = (BitWidth + 1) / 2;
+      if (LimitBits < BitWidth) {
+        APInt Upper = APInt::getOneBitSet(BitWidth, LimitBits);
+        return {
+            {CmpInst::ICMP_ULT, ConstantInt::get(RenamedOp->getType(), Upper)}};
+      }
+    }
+
     CmpInst::Predicate Pred;
     Value *OtherOp;
     if (Cmp->getOperand(0) == RenamedOp) {

llvm/test/Transforms/SCCP/assume-mul-nuw-square.ll

@@ -8,8 +8,7 @@ define i1 @assume_mul_nuw_square_i8(i8 %s) {
 ; CHECK-NEXT:    [[MUL:%.*]] = mul nuw i8 [[S:%.*]], [[S]]
 ; CHECK-NEXT:    [[COND:%.*]] = icmp ule i8 [[MUL]], 120
 ; CHECK-NEXT:    call void @llvm.assume(i1 [[COND]])
-; CHECK-NEXT:    [[CMP:%.*]] = icmp ult i8 [[S]], 16
-; CHECK-NEXT:    ret i1 [[CMP]]
+; CHECK-NEXT:    ret i1 true
 ;
   %mul = mul nuw i8 %s, %s
   %cond = icmp ule i8 %mul, 120
@@ -23,8 +22,7 @@ define i1 @assume_mul_nuw_square_i5(i5 %s) {
 ; CHECK-NEXT:    [[MUL:%.*]] = mul nuw i5 [[S:%.*]], [[S]]
 ; CHECK-NEXT:    [[COND:%.*]] = icmp ult i5 [[MUL]], 15
 ; CHECK-NEXT:    call void @llvm.assume(i1 [[COND]])
-; CHECK-NEXT:    [[CMP:%.*]] = icmp ult i5 [[S]], 8
-; CHECK-NEXT:    ret i1 [[CMP]]
+; CHECK-NEXT:    ret i1 true
 ;
   %mul = mul nuw i5 %s, %s
   %cond = icmp ult i5 %mul, 15
@@ -39,11 +37,9 @@ define i1 @branch_mul_nuw_square(i8 %s, i8 %num) {
 ; CHECK-NEXT:    [[COND:%.*]] = icmp ule i8 [[MUL]], [[NUM:%.*]]
 ; CHECK-NEXT:    br i1 [[COND]], label [[TRUE:%.*]], label [[FALSE:%.*]]
 ; CHECK:       true:
-; CHECK-NEXT:    [[CMP:%.*]] = icmp ult i8 [[S]], 16
-; CHECK-NEXT:    ret i1 [[CMP]]
+; CHECK-NEXT:    ret i1 true
 ; CHECK:       false:
-; CHECK-NEXT:    [[CMP2:%.*]] = icmp ult i8 [[S]], 16
-; CHECK-NEXT:    ret i1 [[CMP2]]
+; CHECK-NEXT:    ret i1 true
 ;
   %mul = mul nuw i8 %s, %s
   %cond = icmp ule i8 %mul, %num