qa: add tests to validate integer value marshaled for i8 values on 64bit systems

Author: weierophinney

src/AbstractValue.php

@@ -44,14 +44,17 @@ abstract class AbstractValue
     protected $xml;
 
     /**
-     * @var \Zend\XmlRpc\Generator\GeneratorInterface
+     * True if BigInteger should be used for XMLRPC i8 types
+     *
+     * @internal
+     * @var bool
      */
-    protected static $generator;
+    public static $USE_BIGINT_FOR_I8 = PHP_INT_SIZE < 8;
 
     /**
-     * True if BigInteger should be used for XMLRPC i8 types
+     * @var \Zend\XmlRpc\Generator\GeneratorInterface
      */
-    public static $USE_BIGINT_FOR_I8 = PHP_INT_SIZE < 8;
+    protected static $generator;
 
     /**
      * Specify that the XML-RPC native type will be auto detected from a PHP variable type

test/BigIntegerValueTest.php

@@ -12,16 +12,22 @@
 use PHPUnit\Framework\TestCase;
 use Zend\XmlRpc\AbstractValue;
 use Zend\XmlRpc\Value\BigInteger;
+use Zend\XmlRpc\Value\Integer;
 use Zend\XmlRpc\Generator\GeneratorInterface as Generator;
 
 /**
  * @group      Zend_XmlRpc
  */
 class BigIntegerValueTest extends TestCase
 {
+    /** @var null|bool */
+    protected $useBigIntForI8Flag;
+
     public function setUp()
     {
+        $this->useBigIntForI8Flag = AbstractValue::$USE_BIGINT_FOR_I8;
         AbstractValue::$USE_BIGINT_FOR_I8 = true;
+
         if (extension_loaded('gmp')) {
             $this->markTestSkipped('gmp causes test failure');
         }
@@ -32,6 +38,12 @@ public function setUp()
         }
     }
 
+    public function tearDown()
+    {
+        AbstractValue::$USE_BIGINT_FOR_I8 = $this->useBigIntForI8Flag;
+        $this->useBigIntForI8Flag = null;
+    }
+
     // BigInteger
 
     /**
@@ -137,4 +149,22 @@ public function wrapXml($xml)
     {
         return $xml . "\n";
     }
+
+    public function testMarshalsIntegerForI8ValueByDefaultIfSystemIs64Bit()
+    {
+        if ($this->useBigIntForI8Flag) {
+            $this->markTestSkipped('Test only valid for 64bit systems');
+        }
+        
+        AbstractValue::$USE_BIGINT_FOR_I8 = $this->useBigIntForI8Flag;
+        $integerValue = PHP_INT_MAX;
+
+        $value = AbstractValue::getXmlRpcValue(
+            $integerValue,
+            AbstractValue::XMLRPC_TYPE_I8
+        );
+
+        $this->assertEquals(AbstractValue::XMLRPC_TYPE_INTEGER, $value->getType());
+        $this->assertSame($integerValue, $value->getValue());
+    }
 }