Skip to content

Conversation

@ES-Alexander
Copy link
Contributor

@ES-Alexander ES-Alexander commented Dec 21, 2025

Closes #12 + closes #13 by replacement, rebasing over main and factoring in relevant feedback (plus a couple of other fixes determined while testing). Includes initial output generations for both, plus a general generation back to the latest generation date (which updates Sub-4.5).

@patrickelectric reviewing is likely easiest by commit rather than by final file state(s).

@ES-Alexander ES-Alexander force-pushed the add-missing-firmware-types branch 2 times, most recently from 00031ac to 2120acb Compare December 21, 2025 05:50
@ES-Alexander ES-Alexander force-pushed the add-missing-firmware-types branch 3 times, most recently from 5a547f4 to 65ef473 Compare December 22, 2025 02:00
@ES-Alexander ES-Alexander force-pushed the add-missing-firmware-types branch from d816eb7 to 708dd0a Compare December 22, 2025 02:09
@ES-Alexander ES-Alexander changed the title Add missing firmware types Add missing firmware types and dev versions Dec 22, 2025
@ES-Alexander
Copy link
Contributor Author

ES-Alexander commented Dec 22, 2025

If we're including development versions, should we stop bothering to process the beta versions? There should always be a corresponding minor that's either stable or dev, unless there's a beta released during a skipped minor (e.g. if ArduSub-4.5 is stable, and ArduSub-4.7 is dev, there could be a unique beta in ArduSub-4.6, although it seems unlikely).

Alternatively, maybe it makes sense to keep betas in a non-versioned folder (e.g. just ArduSub-beta)? With the current sorting, if the minor is the same then the stable will override the beta. I'm not sure what the preferred behaviour is there - stables are fully released (so seem extra worth representing), but betas are sometimes newer 🤷‍♂️

If need be I can update the sort order to properly handle considerations like ArduSub 4.5.0 < ArduSub-beta (on 4.5.1) < ArduSub-4.5.1, but it's fiddly, and then we don't have consistency over which information we lose (e.g. a folder can switch multiple times between representing beta and stable data depending on releases, instead of always being either dev if a new minor, or stable if an existing stable minor).

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The last commit (708dd0a) says Blimp but it changes AP_Peripherals.
  • 580b8f7 has as title: "scripts: run_parsers: include development versions" but it's creating a tag in the repository.
  • The first commit is doing multiple changes at once, can you brean in multiple commits ?
    • It's adding Tracker, Blimp, AP_Periph
    • It's change the logic of get_version_for_tag
    • It's adding staticmethod
    • Moving Groundskeeper to self

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants