-
Notifications
You must be signed in to change notification settings - Fork 16
Add missing firmware types and dev versions #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add missing firmware types and dev versions #16
Conversation
00031ac to
2120acb
Compare
Co-Authored by: ES-Alexander <[email protected]>
5a547f4 to
65ef473
Compare
Co-authored-by: ES-Alexander <[email protected]>
d816eb7 to
708dd0a
Compare
|
If we're including development versions, should we stop bothering to process the beta versions? There should always be a corresponding minor that's either stable or dev, unless there's a beta released during a skipped minor (e.g. if Alternatively, maybe it makes sense to keep betas in a non-versioned folder (e.g. just If need be I can update the sort order to properly handle considerations like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The last commit (708dd0a) says Blimp but it changes AP_Peripherals.
- 580b8f7 has as title: "scripts: run_parsers: include development versions" but it's creating a tag in the repository.
- The first commit is doing multiple changes at once, can you brean in multiple commits ?
- It's adding Tracker, Blimp, AP_Periph
- It's change the logic of get_version_for_tag
- It's adding staticmethod
- Moving Groundskeeper to self
Closes #12 + closes #13 by replacement, rebasing over
mainand factoring in relevant feedback (plus a couple of other fixes determined while testing). Includes initial output generations for both, plus a general generation back to the latest generation date (which updates Sub-4.5).@patrickelectric reviewing is likely easiest by commit rather than by final file state(s).