Skip to content

Conversation

@marker-dao
Copy link
Contributor

No description provided.

@marker-dao marker-dao self-assigned this Dec 29, 2025
@marker-dao marker-dao marked this pull request as ready for review December 29, 2025 14:26
@marker-dao marker-dao requested review from a team as code owners December 29, 2025 14:26
Copilot AI review requested due to automatic review settings December 29, 2025 14:26
pharret31
pharret31 previously approved these changes Dec 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates QUnit tests for editors and related components to ensure compatibility with the Fluent theme, while removing Generic theme testing. The changes primarily involve switching CSS imports from generic_light.css to fluent_blue_light.css and adjusting test assertions to account for theme-specific styling differences in dimensions, margins, and positioning.

Key changes:

  • Theme switch: Updated CSS imports from Generic Light to Fluent Blue Light across multiple test files
  • Test adjustments: Modified assertions for dimensions (width, height, margins) and tolerances to match Fluent theme metrics
  • Code consolidation: Removed separate Generic theme test file for fieldset, incorporating Fluent-only testing approach

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
progressPanel.tests.js Updated icon dimensions from 36px to 40px to match Fluent theme specifications
markup.tests.js Changed CSS import from generic_light to fluent_blue_light
detailsView.tests.js Increased height from 250px to 300px to accommodate Fluent theme layout
toolbarModule.tests.js Changed CSS import from generic_light to fluent_blue_light
toolbarIntegration.tests.js Updated expected HTML content to include inkripple div element
tableResizingIntegration.tests.js Added HTML_EDITOR_CONTENT_MARGIN constant and adjusted multiple assertion tolerances and position calculations
tableProperties.tests.js Updated assertion tolerances and expected widths for table/cell dimensions
resizingIntegration.tests.js Added HTML_EDITOR_CONTENT_MARGIN and adjusted frame positioning assertions
imageUploadIntegration.tests.js Changed form labelLocation from 'left' to 'top'
textArea.tests.js Changed theme import and added TEXTEDITOR_INPUT_CONTAINER_CLASS with margin calculations
slider.tests.js Changed theme import, updated SLIDER_PADDING from 7 to 10, and adjusted tolerance
fieldset_bundled.tests.js Major refactoring to hardcode Fluent theme, removed Generic theme support, adjusted assertions for theme-specific alignments
fieldset_bundled.generic.tests.js Deleted file (removing Generic theme testing)

r-farkhutdinov
r-farkhutdinov previously approved these changes Dec 29, 2025
@marker-dao marker-dao dismissed stale reviews from r-farkhutdinov and pharret31 via dfcc0c4 December 29, 2025 17:40
@marker-dao marker-dao merged commit 768ff90 into DevExpress:26_1 Dec 29, 2025
115 of 116 checks passed
@marker-dao marker-dao deleted the switchTestsToFluent__26_1 branch December 29, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants