-
Notifications
You must be signed in to change notification settings - Fork 42
[MOB-7052] Embedded messaging feature #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…OB-12260-create-embedded-tab-in-example-app
…-app' into loren/embedded/MOB-12261-add-embedded-manager-class
…-app' into loren/embedded/MOB-12261-add-embedded-manager-class
…to loren/embedded/MOB-12263-android-add-ability-to-sync-embedded-messages
…terableAPIModuleImpl
…RNIterableAPIModule
…mbeddedMessaging flag
…eate-embedded-tab-in-example-app
…-app' into loren/embedded/MOB-12261-add-embedded-manager-class
…to loren/embedded/MOB-12263-android-add-ability-to-sync-embedded-messages
…bedded-messages' into loren/embedded/MOB-12265-start-end-session
…embedded/MOB-12264-android-sync-and-get-messages
… into loren/embedded/MOB-12267-android-add-start-impression-and-pause-impressio
…nd-pause-impressio' into loren/embedded/MOB-12268-android-add-click-handling-and-track
…-embedded-tab-in-example-app [MOB-12260] create-embedded-tab-in-example-app
…d-embedded-manager-class
…bedded-manager-class [MOB-12261] Add IterableEmbeddedManager class
…d-add-ability-to-sync-embedded-messages [MOB-12263] android-add-ability-to-get placements
…embedded/MOB-12264-android-sync-and-get-messages
…end-session [MOB-12265] Configure start and end session
…droid-sync-and-get-messages
…d-sync-and-get-messages [MOB-12264] Add sync messages and get messages to android
android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java
Show resolved
Hide resolved
android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java
Show resolved
Hide resolved
…droid-add-start-impression-and-pause-impressio
…d-add-start-impression-and-pause-impressio [MOB-12267] add pauseEmbeddedImpression method to manage embedded message impressions
…d-add-click-handling-and-track [MOB-12268] Add click handling and tracking
android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java
Show resolved
Hide resolved
| /** | ||
| * The config for the Iterable SDK. | ||
| */ | ||
| private _config: IterableConfig = new IterableConfig(); |
Check warning
Code scanning / CodeQL
Useless assignment to property Warning
another property write
| } catch (JSONException e) { | ||
| IterableLogger.e(TAG, e.getLocalizedMessage()); | ||
| promise.reject("", "Failed to fetch messages with error " + e.getLocalizedMessage()); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 'Notification permission not required for this Android version.' | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .catch((reason) => { | ||
| IterableLogger?.log('Error opening url: ' + reason); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (str.startsWith(IterableCustomActionPrefix.Itbl)) { | ||
| return IterableCustomActionPrefix.Itbl; | ||
| } | ||
| return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const actionDetails = new IterableAction('openUrl', clickedUrl, ''); | ||
| const context = new IterableActionContext(actionDetails, source); | ||
| callUrlHandler(this._config, clickedUrl, context); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔹 JIRA Ticket(s) if any
✏️ Description
Adds the embedded messaging feature
This contains the following PRS: