Skip to content

Conversation

lposen and others added 30 commits October 10, 2025 15:08
…-app' into loren/embedded/MOB-12261-add-embedded-manager-class
…-app' into loren/embedded/MOB-12261-add-embedded-manager-class
…to loren/embedded/MOB-12263-android-add-ability-to-sync-embedded-messages
lposen and others added 11 commits December 11, 2025 13:39
…-app' into loren/embedded/MOB-12261-add-embedded-manager-class
…to loren/embedded/MOB-12263-android-add-ability-to-sync-embedded-messages
…bedded-messages' into loren/embedded/MOB-12265-start-end-session
…embedded/MOB-12264-android-sync-and-get-messages
… into loren/embedded/MOB-12267-android-add-start-impression-and-pause-impressio
…nd-pause-impressio' into loren/embedded/MOB-12268-android-add-click-handling-and-track
…-embedded-tab-in-example-app

[MOB-12260] create-embedded-tab-in-example-app
…bedded-manager-class

[MOB-12261] Add IterableEmbeddedManager class
…d-add-ability-to-sync-embedded-messages

[MOB-12263] android-add-ability-to-get placements
…embedded/MOB-12264-android-sync-and-get-messages
…end-session

[MOB-12265] Configure start and end session
…d-sync-and-get-messages

[MOB-12264] Add sync messages and get messages to android
lposen and others added 5 commits December 17, 2025 17:15
…droid-add-start-impression-and-pause-impressio
…d-add-start-impression-and-pause-impressio

[MOB-12267] add pauseEmbeddedImpression method to manage embedded message impressions
…d-add-click-handling-and-track

[MOB-12268] Add click handling and tracking
/**
* The config for the Iterable SDK.
*/
private _config: IterableConfig = new IterableConfig();

Check warning

Code scanning / CodeQL

Useless assignment to property Warning

This write to property '_config' is useless, since
another property write
always overrides it.
} catch (JSONException e) {
IterableLogger.e(TAG, e.getLocalizedMessage());
promise.reject("", "Failed to fetch messages with error " + e.getLocalizedMessage());
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 11): getEmbeddedMessages [qlty:function-complexity]

'Notification permission not required for this Android version.'
);
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 15): requestNotificationPermission [qlty:function-complexity]

.catch((reason) => {
IterableLogger?.log('Error opening url: ' + reason);
});
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 5): callUrlHandler [qlty:function-complexity]

if (str.startsWith(IterableCustomActionPrefix.Itbl)) {
return IterableCustomActionPrefix.Itbl;
}
return null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 issues:

1. Function with many returns (count = 4): getActionPrefix [qlty:return-statements]


2. Function with high complexity (count = 6): getActionPrefix [qlty:function-complexity]

const actionDetails = new IterableAction('openUrl', clickedUrl, '');
const context = new IterableActionContext(actionDetails, source);
callUrlHandler(this._config, clickedUrl, context);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 7): handleClick [qlty:function-complexity]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

embedded Issues/PRs related to Embedded Messages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants