Add CV/NLP SymDim Reifier matching error msg. #502
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
lixinqi
reviewed
Dec 26, 2025
Comment on lines
+19
to
+26
| if sym_shapes_str == "[]": | ||
| return False | ||
| assert sym_shapes_str in self._get_map_cv_sym_shapes_str2reifier(), ( | ||
| "[CV SymDim Reify] No reifier matched symbolic shapes:\n" | ||
| f"{sym_shapes_str}\n" | ||
| "Please add a reify rule to _get_map_cv_sym_shapes_str2reifier()." | ||
| ) | ||
| return True |
Collaborator
There was a problem hiding this comment.
肯定不是改这里啊。match是一个检测接口，它不能崩溃的。
TelGome
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Bug Fix
Description
Fix CV/NLP SymDim Reifier matching semantics.