ensure 3d points' 4th coordinate is set to 1 #6362
Open
+26
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… behave as expected for custom point types without additional constructors
Contributor
Author
|
How can i re-run the checks? Cant see why CI cannot build it. |
Member
|
Since the CI logs keep getting deleted after 2 weeks or so: Honestly not sure how to solve this. Maybe adding a note to the documentation instead is sufficient? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make vector4f maps to behave as expected for custom point types without additional constructors.
Got bitten by this since i made a custom point type without custom constructor and a library was expecting the points to be homogeneous and computed hard to debug garbage.