Update samples to dotnet 10 #431
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates all sample projects from .NET 8 to .NET 10, aligning with the latest framework version and Visual Studio project templates. The changes include framework target updates, package version bumps, and modernized static asset handling.
Key changes:
- Updated target framework from net8.0 to net10.0 across all projects
- Upgraded dependency package versions (ASP.NET Core, EF Core, MongoDB, Cosmos DB, MySQL)
- Modernized static file handling using new
MapStaticAssets()andWithStaticAssets()APIs - Updated project templates to match VS defaults (launch settings, CSS, validation scripts)
Reviewed changes
Copilot reviewed 42 out of 1009 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| **/*.csproj | Updated TargetFramework to net10.0 and package versions |
| **/Directory.Build.props | Updated AspNetCoreVersion and EFCoreVersion to 10.0.* |
| **/Program.cs | Replaced UseStaticFiles() with MapStaticAssets() and added WithStaticAssets() |
| **/launchSettings.json | Updated schema URL to HTTPS and removed IIS Express profiles |
| **/README.md | Updated documentation references from .NET 8 to .NET 10 SDK |
| **/*.feature | Updated test scenarios from net8.0 to net10.0 |
| **/css/site.css | Added new form-floating placeholder styles |
| **/_Layout.cshtml | Added empty importmap script tag |
| **/_ValidationScriptsPartial.cshtml | Updated jquery-validation-unobtrusive path to include /dist/ |
| Configuration/src/ConfigurationProviders/appsettings.json | Renamed configuration key for clarity |
| Configuration/src/ConfigurationProviders/Views/Home/PlaceholderValues.cshtml | Updated to display PATH variable with platform-specific formatting |
| .github/workflows/shared-test-workflow.yml | Updated dotnet-version to 10.0.* |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Configuration/src/ConfigurationProviders/Views/Home/PlaceholderValues.cshtml
Outdated
Show resolved
Hide resolved
Configuration/src/ConfigurationProviders/Views/Home/PlaceholderValues.cshtml
Outdated
Show resolved
Hide resolved
|
@bart-vmware I've opened a new pull request, #432, to work on those changes. Once the pull request is ready, I'll request review from you. |
bart-vmware
force-pushed
the
update-samples-to-dotnet-10
branch
from
465b166 to
b195866
Compare
…figure the absolute URL to register with
* Initial plan * Fix XSS vulnerability by HTML-encoding before replacing delimiters Co-authored-by: bart-vmware <[email protected]> * Remove unnecessary null-conditional operator after Html.Encode Co-authored-by: bart-vmware <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: bart-vmware <[email protected]>
bart-vmware
force-pushed
the
update-samples-to-dotnet-10
branch
from
b195866 to
768a053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all sample projects to .NET 10 and updates package versions. Synced up with changes in VS project templates.
I've tested running the samples:
I'd like to get this merged before further testing on Dhaka, so we can run our integration tests on it.
To review, I recommend skipping the
wwwrootdirectories. I replaced their contents with the files from the updated VS project templates. One notable template change is that files inwwwroot/lib/jquery-validation-unobtrusivehave moved into adistsubdirectory (presumably to align with how the other libs are organized).