Skip to content

Use the directory username to search for accounts when changing the email attribute #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mwilmes-at-avc wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

Use the directory username to search for accounts when changing the email attribute #871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion user_sync/engine/umapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,7 +894,13 @@ def update_umapi_user(self, umapi_info, user_key, attributes_to_update=None, gro
directory_user['email'] = umapi_user['email']
directory_user['username'] = umapi_user['email']

commands = user_sync.connector.connector_umapi.Commands(directory_user['email'], directory_user['domain'])
# if the username is not an email address, matches in both directories, and the email address is changing, then we need to lookup by username.
if '@' not in directory_user['username'] and directory_user['username'] == umapi_user['username'] and normalize_string(directory_user['email']) != normalize_string(umapi_user['email']):
user_lookup = directory_user['username']
else:
user_lookup = directory_user['email']

commands = user_sync.connector.connector_umapi.Commands(user_lookup, directory_user['domain'])
commands.update_user(attributes_to_update)
commands.remove_groups(groups_to_remove)
commands.add_groups(groups_to_add)
Expand Down