Skip to content

Conversation

@SGZW
Copy link
Contributor

@SGZW SGZW commented Dec 23, 2025

Purpose

Linked issue: close #xxx

background: compile and run under gcc8
1.

src/paimon/common/file_index/file_index_format_test.cpp

unordered_map iterate order is undefined, so make ut not depend on the order of return vector's element order

Tests

API and Format

Documentation

@SGZW
Copy link
Contributor Author

SGZW commented Dec 23, 2025

@lxy-9602 PTAL,Thanks

@lucasfang lucasfang requested a review from Copilot December 23, 2025 09:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@SGZW
Copy link
Contributor Author

SGZW commented Dec 23, 2025

@lxy-9602 @ChaomingZhangCN PTAL, thanks

@ChaomingZhangCN
Copy link
Contributor

In that case, the integration test case ReadInteTest#TestAppendReadWithComplexTypePredicate should also fail.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SGZW
Copy link
Contributor Author

SGZW commented Dec 24, 2025

In that case, the integration test case ReadInteTest#TestAppendReadWithComplexTypePredicate should also fail.

I’m building the project with Blade, and I haven’t run the integration tests yet. I’ve already run into some issues with the unit tests, so I’ll look into them further.

@SGZW SGZW requested a review from lucasfang December 24, 2025 16:33
Copy link
Collaborator

@lxy-9602 lxy-9602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lxy-9602 lxy-9602 merged commit 21b5afc into alibaba:main Dec 25, 2025
11 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants