-
Notifications
You must be signed in to change notification settings - Fork 14
fix(compile, ut): some compile/ut issues #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@lxy-9602 PTAL,Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
@lxy-9602 @ChaomingZhangCN PTAL, thanks |
|
In that case, the integration test case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I’m building the project with Blade, and I haven’t run the integration tests yet. I’ve already run into some issues with the unit tests, so I’ll look into them further. |
lxy-9602
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Purpose
Linked issue: close #xxx
background: compile and run under gcc8
1.
unordered_map iterate order is undefined, so make ut not depend on the order of return vector's element order
Tests
API and Format
Documentation