-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-38807][state] Add state SQL metadata based type inference #27340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2bbeace to
f815832
Compare
| ... | ||
| } | ||
|
|
||
| public class AvroSavepointTypeInformationFactory implements SavepointTypeInformationFactory { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should deprecate classes rather than just remove, and give advice on how to move to the new way of doing things. I suppose this could be a back port consideration only - if we take this approach then a comment reminder would be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecate from test code?🙂 The new way is that Flink finds this out automatically but the SavepointTypeInformationFactory approach remains as safety belt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaborgsomogyi my bad. I did not look closely enough. If the SavepointTypeInformationFactory approach remains as safety belt, I suggest we keep the deleted tests that refer to this approach - I assume these tests would still work if there is no metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're working but the whole intention is is to infer types and make user's life easier. The SavepointTypeInformationFactory approach would worth to add a new test though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added test coverage
d7f1ad9 to
e0a5cf9
Compare
e0a5cf9 to
34c44c9
Compare
What is the purpose of the change
This PR enhances SQL state API internally to infer savepoint types from savepoint metadata which eliminates almost all
value-classandkey-type-factorySQL option usages. The trick is simple, use serializers coming from metadata. Serialized classes still needs to be on classpath.Brief change log
MAP<bigint, bigint>type toMAP<string, bigint>to introduce differenceVerifying this change
Modified tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation