Skip to content

Conversation

@EvilOlaf
Copy link
Member

@EvilOlaf EvilOlaf commented Dec 17, 2025

Description

overlay subdir was missing vom Makefile, so the overlay creation was skipped.
Has been reported here: https://forum.armbian.com/topic/56756-no-overlays-when-kernel-6181-edge-sunxi-compile/

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • New Features
    • Device tree overlay support is now built into Armbian, providing enhanced hardware configuration capabilities and greater customization options for Armbian devices on Allwinner platforms.

✏️ Tip: You can customize this high-level summary in your review settings.

The autopatcher thingy seems borked as it seems this line should be included automatically (??)
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 17, 2025

Walkthrough

A single line is added to arch/arm/boot/dts/allwinner/Makefile to include the overlay subdirectory in the kernel device-tree build traversal, enabling overlay artifacts to be built alongside existing device-tree sources.

Changes

Cohort / File(s) Summary
Device-tree overlay build configuration
arch/arm/boot/dts/allwinner/Makefile
Added subdir-y := $(dts-dirs) overlay to include overlay subdirectory in the build traversal

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Suggested reviewers

  • igorpecovnik
  • leggewie

Poem

🐰 A little line, so small and sweet,
Makes overlay builds complete!
The subdir-y now points the way,
To build more overlays every day! 🌳

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding a missing overlay subdirectory entry to the Makefile to enable device-tree overlay creation for sunxi.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added 02 Milestone: First quarter release size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Dec 17, 2025
coderabbitai[bot]

This comment was marked as outdated.

@EvilOlaf

This comment was marked as outdated.

@coderabbitai

This comment was marked as outdated.

@EvilOlaf

This comment was marked as outdated.

@coderabbitai

This comment was marked as outdated.

@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Dec 17, 2025
@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Dec 17, 2025
@igorpecovnik igorpecovnik merged commit 13c79f6 into armbian:main Dec 18, 2025
12 checks passed
@EvilOlaf EvilOlaf deleted the sunxi-overlay-fix branch December 18, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants