Skip to content

Adding CRC combine functions and updating aws-checksums submodule #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pulimsr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding CRC combine functions and updating aws-checksums submodule #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crt/aws-checksums
Open in desktop
Submodule aws-checksums updated 16 files
+7 −7 .github/workflows/ci.yml
+2 −2 .github/workflows/handle-stale-discussions.yml
+1 −1 .github/workflows/stale_issue.yml
+63 −0 include/aws/checksums/crc.h
+12 −0 include/aws/checksums/private/crc32_priv.h
+7 −0 include/aws/checksums/private/crc64_priv.h
+5 −1 include/aws/checksums/private/crc_util.h
+57 −0 source/arm/crc64_arm.c
+581 −1 source/crc32.c
+313 −1 source/crc64.c
+46 −0 source/crc64_sw.c
+69 −0 source/crc_sw.c
+63 −0 source/crc_util.c
+3 −0 tests/CMakeLists.txt
+41 −0 tests/crc64_test.c
+82 −0 tests/crc_test.c
15 changes: 15 additions & 0 deletions include/aws/crt/checksum/CRC.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,21 @@ namespace Aws
* the non bit-reflected polynomial 0xad93d23594c93659) and inverts the CRC input and output bits.
*/
uint64_t AWS_CRT_CPP_API ComputeCRC64NVME(ByteCursor input, uint64_t previousCRC64NVME = 0) noexcept;

/**
* Combines two CRC32 (Ethernet, gzip) checksums computed over separate data blocks.
*/
uint32_t AWS_CRT_CPP_API CombineCRC32(uint32_t crc1, uint32_t crc2, uint64_t len2) noexcept;

/**
* Combines two CRC32C (Castagnoli, iSCSI) checksums computed over separate data blocks.
*/
uint32_t AWS_CRT_CPP_API CombineCRC32C(uint32_t crc1, uint32_t crc2, uint64_t len2) noexcept;

/**
* Combines two CRC64-NVME checksums computed over separate data blocks.
*/
uint64_t AWS_CRT_CPP_API CombineCRC64NVME(uint64_t crc1, uint64_t crc2, uint64_t len2) noexcept;
} // namespace Checksum
} // namespace Crt
} // namespace Aws
15 changes: 15 additions & 0 deletions source/checksum/CRC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,21 @@ namespace Aws
return aws_checksums_crc64nvme_ex(input.ptr, input.len, previousCRC64NVME);
}

uint32_t CombineCRC32(uint32_t crc1, uint32_t crc2, uint64_t len2) noexcept
{
return aws_checksums_crc32_combine(crc1, crc2, len2);
}

uint32_t CombineCRC32C(uint32_t crc1, uint32_t crc2, uint64_t len2) noexcept
{
return aws_checksums_crc32c_combine(crc1, crc2, len2);
}

uint64_t CombineCRC64NVME(uint64_t crc1, uint64_t crc2, uint64_t len2) noexcept
{
return aws_checksums_crc64nvme_combine(crc1, crc2, len2);
}

} // namespace Checksum
} // namespace Crt
} // namespace Aws