fix(pull): properly handle non-DockerHub registry refs #1128
+37
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
reviewed
Dec 18, 2025
| return "", fmt.Errorf("creating content store: %w", err) | ||
| } | ||
|
|
||
| localRef := ref.Context().RepositoryStr() + separator(ref) + ref.Identifier() |
Member
There was a problem hiding this comment.
This is the line that removes the registry from the reference, instead of adding a second link, could we make it so that the reference still has the registry in it?
Author
There was a problem hiding this comment.
Hmm, so, we should basically do localRef := ref.String(), as there's no point of constructing this if we want to keep the registry?
I believe this would change the hashes for DockerHub images and will require users to pull them again, won't it? It might not be a big deal, but just want to be sure we're not breaking anything.
Also, if we doing this, should we delete separator() and its tests, as that's the only place it's used in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1127
Fixes #1080