Skip to content

cli: Update docs #23861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vvoland wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cli: Update docs #23861

vvoland wants to merge 1 commit into from

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Dec 17, 2025 •
edited
Loading

Description

The cli docs haven't been imported for a while. We should automate this somehow.

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link

netlify bot commented Dec 17, 2025 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 4065ed0
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/69440ac8a17269000850ec95
😎 Deploy Preview https://deploy-preview-23861--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the area/cli Relates to the CLI client label Dec 17, 2025
@vvoland
Copy link
Contributor Author

vvoland commented Dec 18, 2025 •
edited
Loading

Looks like there's some error in the CLI docs:

 #28 0.048 ========================================================================
#28 2.069 reference/cli/docker/container/run/index.html
#28 2.069   hash does not exist --- reference/cli/docker/container/run/index.html --> /desktop/features/networking/networking-how-tos/#i-want-to-connect-from-a-container-to-a-service-on-the-host
#28 2.069 ========================================================================

@vvoland vvoland mentioned this pull request Dec 18, 2025
Open
thaJeztah
thaJeztah reviewed Dec 18, 2025
View reviewed changes
data/engine-cli/docker_service_update.yaml Outdated
Comment on lines 443 to 445
min_api_version: "1.41"
min_api_version: "1.52"
Copy link
Member

@thaJeztah thaJeztah Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting; curious if this was some mistake somewhere; let me check

Copy link
Member

@thaJeztah thaJeztah Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! never mind this is for docker service, so probably correct

Copy link
Member

@thaJeztah thaJeztah Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope; it is a bug / mistake; looks like some copy/pasta same flag-name repeated here; https://github.com/docker/cli/blob/93fa57bbcd08f2f5be7f6cf22f4273a2b5a49e71/cli/command/service/opts.go#L905-L910

Copy link
Member

@thaJeztah thaJeztah Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vvoland vvoland mentioned this pull request Dec 18, 2025
Merged
@thaJeztah thaJeztah mentioned this pull request Dec 18, 2025
Merged
@vvoland
Copy link
Contributor Author

vvoland commented Dec 18, 2025

Actually, gave it a quick try to make a workflow that does this automatically: #23867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/cli Relates to the CLI client

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vvoland @thaJeztah