-
Notifications
You must be signed in to change notification settings - Fork 7
fix(actions): improve onboarding messaging & remove invalid token check #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ubayed-Bin-Sufian
wants to merge
5
commits into
fossasia:master
Choose a base branch
from
Ubayed-Bin-Sufian:feature/improve-codeheat-contributor-onboarding
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−16
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
61cd44f
fix(actions): improve onboarding messaging & remove invalid token check
Ubayed-Bin-Sufian e3f322b
fix: use env variable for secret validation in bash script
Ubayed-Bin-Sufian b1070ae
fix: add early return on non-404 membership check errors
Ubayed-Bin-Sufian dec590c
fix: add error handling for org invitation failures
Ubayed-Bin-Sufian b487322
fix: check membership state instead of invited flag for user messaging
Ubayed-Bin-Sufian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Org membership text can be incorrect for existing but pending members.
When
getMembershipForUserreturnsstate === 'pending'for an existing membership,invitedstaysfalse, soorgStatusLinebecomes"• Org membership: **already active**", even though the lateractionMessagelogic correctly treats this as pending. Please deriveorgStatusLinefrommembership.data.statein both cases (or at least special-casependingwheninvited === false) so the status text matches the actual membership state.