-
Notifications
You must be signed in to change notification settings - Fork 11
Show servers defined in workspace folder settings in UI #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show servers defined in workspace folder settings in UI #273
Conversation
|
@gjsjohnmurray I am not sure how to publish a new version of the types to get the CI to pass. |
|
I have drafted PR #275 and published @intersystems-community/[email protected] on npmjs.com Please update package.json in your PR to use that beta, which I hope will fix the CI failure. Assuming it does, and no more changes are required in types/index.d.ts to complete your PR, I will update mine to remove the beta tag, publish 3.10.2 and ask you to approve my PR. Then you should be able to yours to remove the -beta.1 suffix on the devDependencies line. |
|
Now ready for your change to the devDependencies line, removing the -beta.1 suffix. Please also update your branch from master. |
|
Do you want to get the dev VSIX validated by the customer who raised the issue? |
|
@gjsjohnmurray I will double-check this myself before merging. |
|
This looks good to me. The workspace folder specific servers do not appear in the "All Servers" tree, just "Current". I think that is fine for now and I will attempt to address that in a separate PR. |
This PR fixes #272. I will tackle the "Add Server" command item in a separate PR because it's an enhancement.