Fix resolving of server connection for files opened from InterSystems Explorer or XML preview #1622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Explorer or XML preview
Contributor
Author
|
@gjsjohnmurray @isc-rsingh I would appreciate a review on this today so we can proceed with the release. |
gjsjohnmurray
approved these changes
Jul 21, 2025
Contributor
gjsjohnmurray
left a comment
gjsjohnmurray
left a comment
There was a problem hiding this comment.
Looks OK but not personally tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
objectscript(xml)://URIs are not in a workspace folder, resolving server connection information for them didn't always work. This lead to issues like a lack of intellisense in those files or the server connection for the current workspace being forced inactive. This also caused Language Server to prompt for a password when not necessary because this extension would not return the password when it was defined in plain text.