feat!: using node14 with type:module #434
Conversation
antialias
changed the title
| strategy: | ||
| matrix: | ||
| node: [10, 12, 14] | ||
| node: [14.15.1] |
There was a problem hiding this comment.
If only one version is tested, a matrix is not needed. But it may still be useful to test in different Node.js versions.
Also, I believe 14 would use the latest 14 version, so we don't need to set the complete version. (same below and in .npmrc)
| "version": "0.0.0-development", | ||
| "description": "The JSON Resume command line interface", | ||
| "main": "index.js", | ||
| "type": "module", |
There was a problem hiding this comment.
Should this be in the published package.json once we compile the source with Babel? Not sure anyone is importing resume-cli, but still.
|
I believe this is not a breaking change if we merge #433 first. |
thomasdavis
left a comment
thomasdavis
left a comment
There was a problem hiding this comment.
I think just keep the testing on multiple node versions for now, see how it goes with the babel PR.
|
setting this to "draft" because it appears that jest is still working on support for ES6 modules, and my attempts to get it working using experimental flags have so far been unsuccessful. relevant jest issue here: jestjs/jest#9430 |
3 participants
No description provided.