[bazel] Add potential bzlmod inclusion example #173124
Open
+66
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the MODULE.bazel is not at the root of the repo, there is some complexity on how to include this in your own bazel project using bzlmod. This example pulls the repo as llvm-raw, patches the MODULE.bazel (notably putting it in the root of the repo), and then sets up the llvm-project repository. This isn't ideal and I'm not sure if we'd really want to use the llvm-raw name in the BCR, but I wanted to put this up for discussion
keith
commented
Dec 20, 2025
| }, | ||
| ) | ||
|
|
||
| def _llvm_impl(mctx): |
Member
Author
There was a problem hiding this comment.
this configure setup needs to be callable multiple times from multiple contexts so that it can view all the repositories from the MODULE.bazel in this repo. this is virtually copied from https://github.com/cerisier/toolchains_llvm_bootstrapped/blob/a6e8188bad743b8fa05be68642edf253811fe9ac/llvm.bzl#L3-L17
the biggest implementation question is how targets should combine, in the current implementation it only respects the root repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the MODULE.bazel is not at the root of the repo, there is some
complexity on how to include this in your own bazel project using
bzlmod.
This example pulls the repo as llvm-raw, patches the MODULE.bazel
(notably putting it in the root of the repo), and then sets up the
llvm-project repository.
This isn't ideal and I'm not sure if we'd really want to use the
llvm-raw name in the BCR, but I wanted to put this up for discussion