[Matrix] Add basic single subscript tests #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes llvm#630 This change just does single subscript gets\sets. It reserves swizzle use to only when a matrix single index is constant in the subscript.
farzonl
force-pushed
the
task/single-subscript-basic-issue-630
branch
from
dd01ce9 to
e683e20
Compare
farzonl
added
the
test-all
spall
reviewed
Dec 18, 2025
farzonl
force-pushed
the
task/single-subscript-basic-issue-630
branch
from
1eec657 to
8202a1f
Compare
spall
approved these changes
Dec 19, 2025
| Data: [ 1, 2, 3, 4, 5, 6] | ||
| - Name: Index | ||
| Format: Int32 | ||
| Data: [ 1, 0] |
Collaborator
There was a problem hiding this comment.
index at zero isn't used? You could make this of size 1?
Icohedron
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #630
This change just does single subscript gets\sets.
It reserves swizzle use to only when a matrix single index is constant in the subscript.