Pre-computed tooltips implemented. #95
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draklos
force-pushed
the
master
branch
3 times, most recently
from
6f0a495 to
115cac3
Compare
max0x7ba
requested changes
Dec 23, 2025
html/benchmarks.js
Outdated
| data: stats.map(a => [a[0], a[3]]), | ||
| atomic_queue_stats: stats, | ||
| data: stats.map((a) => { | ||
| const [mean, stdev, min, max] = [a[3], a[4], a[1], a[2]].map(prec0); |
Owner
There was a problem hiding this comment.
It should map over a[1:] slice. Indexing individual elements of a defeats the purpose of using map.
What is the intention behind this absurd order of identifiers in the destructuring statement?
max0x7ba
reviewed
Dec 23, 2025
html/benchmarks.js
Outdated
| <span class="tooltip_scalability_title">${n_threads} producers, ${n_threads} consumers</span> | ||
| const { x, points } = this; | ||
| const rows = points | ||
| .filter(({ series }) => series.visible) |
Owner
There was a problem hiding this comment.
I don't think disabled series elements are present in the points array. Am I wrong?
max0x7ba
reviewed
Dec 23, 2025
html/benchmarks.js
Outdated
| const rows = points | ||
| .filter(({ series }) => series.visible) | ||
| .map(point => point.options.tooltip_row) | ||
| .join(''); |
Owner
There was a problem hiding this comment.
For easy unanticipated debugging it is best for tooltip html to be nicely formatted for best readability. E.g. when you hover your mouse over rows variable in the debugger, often accidentally, you don't want to see all rows packed into one huge unreadable line, do you?
Contributor
Author
|
Thank you for the review! The changes to the remarks have been pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.