-
Notifications
You must be signed in to change notification settings - Fork 247
Self healing open #7189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Self healing open #7189
Conversation
Co-authored-by: Eddy Ashton <[email protected]>
src/node/self_healing_open_impl.cpp
Outdated
|
|
||
| auto url = fmt::format( | ||
| "https://{}/{}/self_healing_open/timeout", | ||
| node_state->config.network.rpc_interfaces.at("primary_rpc_interface") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want this to take place over the same rpc interface we use for snapshot download, joining etc, which is probably not the primary as that tends to be exposed publicly. Perhaps that's a configuration option? Perhaps we need to name that interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this such that all self-healing-open messages pass through the same interface, which in theory should be on a private vnet etc, and is set in the config.
In general having a concept of an internal interface (one used for snapshots, joining, ledgers etc) would be useful (as we can centrally manage it), but that is probably a bigger discussion we should have in the new year.
tla/disaster-recovery/src/main.rs
Outdated
| fn check(model: ActorModel<Node, ModelCfg, ()>) { | ||
| let checker = model | ||
| .checker() | ||
| //.symmetry() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaicr symmetry can interact badly with the eventually properties.
Co-authored-by: Amaury Chamayou <[email protected]>
This PR is the reification of: #7003
The idea is that if a service has fully crashed, it should be able to heal itself so long as it isn't too damaged.
Specifically, the restarting nodes should gossip the knowledge they have locally to try and elect the replica with the best local state.
The result is that after the self-healing-open one replica is chosen to recover and open, while all others restart to then join it.
The protocol can be roughly surmised as:
transition_to_openand broadcastIAmOpento the other nodes.IAmOpenfrom a trusted node, restart and join it.This still requires the submission of ledger recovery shares, however if local sealing is available those can be used instead.
UPDATE:
To be specific on when and where things happen.
createrpc it will reset the self-healing-open state and once that state is committed start several timers, one to resend gossips/votes/iamopen messages, and one to advance the failover state-machinetransition-to-openand on the next timer tick stops the timers.