-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
PointLight/SpotLight: Deprecate distance parameter, auto-compute from intensity and decay. #32543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
Improved Screen.Recording.2025-12-13.at.17.16.29.mov |
85e73b4 to
646e7f0
Compare
|
Seems like |
|
Note that this will mean dropping support for the
That said, I don't know if it's applied in this way by three.js users. If we prefer to not support this field in the glTF extension spec, that's OK with me. |
Description
The
distanceparameter was redundant - it can be derived from the physically-basedintensityanddecayvalues. This simplifies the API and ensures consistency between visual range and actual light falloff.