Skip to content

Conversation

@jiridanek
Copy link
Member

@jiridanek jiridanek commented Dec 15, 2025

Description

Creating LVM Volume.
  Creating LVM PV on root fs.
losetup: cannot find an unused loop device: No such file or directory
  No device found for .

The IBM runners are containers, not VMs, so I can't do these partitioning operations. And there isn't a separate volume for /mnt (or any other directory) anyways, so there is no point to it.

This is easy to make conditional, no big deal.

Homebrew on Linux is only supported on Intel x86_64 and ARM64 processors!

This is a significant problem; so far we used Homebrew to get latest (recent) Podman.

  • Ubuntu 24.04 has relatively recent Podman 4.x already, so maybe we should just use the distro podman
  • There was the Suse opensource build service build we may use
  • Some random person is publishing statically linked podman binaries on github
  • nixpkgs probably has broader platform support than homebrew
  • Fedora chroot could be created

For sure it would be strange to maintain multiple ways of getting podman, so if we proceed with IBM runners, then Homebrew for Linux is most likely out.

The trouble with switching to OS version of Podman is that the config files assume currently Homebrew, so I'd need to change the configs.

How Has This Been Tested?

Let's see if the IBM runners will activate on a PR; if not

In fact they do activate for PRs, so that's good!

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jiridanek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel label Dec 15, 2025
@openshift-ci openshift-ci bot added size/m and removed size/m labels Dec 15, 2025
NO-JIRA: chore(workflows): update trivy

NO-JIRA: chore(workflows): update pre-commit tooks

NO-JIRA: chore(workflows): update `setup-uv` action to version `v7` in security workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel size/xl

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant