Skip to content

[rustdoc] Add missing close tags in extern crate reexports #150185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lambda wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[rustdoc] Add missing close tags in extern crate reexports #150185

lambda wants to merge 2 commits into from
+10 −0

Conversation

@lambda
Copy link
Contributor

@lambda lambda commented Dec 20, 2025 •
edited by rustbot
Loading

Fixes #150176

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Dec 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Dec 20, 2025

Looks good to me, thanks! Please add a regression test in tests/rustdoc to ensure the HTML is correctly generated.

@rustbot

This comment has been minimized.

Sign in to view
@lambda lambda force-pushed the rustdoc-missing-close-tags-reexport branch from 53d9ddd to c556e9c Compare December 20, 2025 15:40
@lambda
Copy link
Contributor Author

lambda commented Dec 20, 2025

Added a test that passes, but now I'm wondering why we don't have a link to the inner crate. I would expect there to be an <a> around inner linking to the extern crate docs.

@lambda
Copy link
Contributor Author

lambda commented Dec 20, 2025

Ah, figured it out, I need //@ build-aux-docs to get that. Started to add that, but then realized that this test is simpler and less fragile without having to match the link, so I think it's better to leave it as is.

GuillaumeGomez
GuillaumeGomez reviewed Dec 20, 2025
View reviewed changes
GuillaumeGomez
GuillaumeGomez reviewed Dec 20, 2025
View reviewed changes
@lambda lambda force-pushed the rustdoc-missing-close-tags-reexport branch from 283c163 to 685e4b6 Compare December 21, 2025 05:58
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Dec 21, 2025

Thanks a lot!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 21, 2025

📌 Commit 685e4b6 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2025
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 21, 2025
@JonathanBrouwer
Rollup merge of rust-lang#150185 - lambda:rustdoc-missing-close-tags-…
05e4bdd 
…reexport, r=GuillaumeGomez

[rustdoc] Add missing close tags in extern crate reexports

Fixes rust-lang#150176
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 21, 2025
Closed
bors added a commit that referenced this pull request Dec 21, 2025
@bors
Auto merge of #150224 - JonathanBrouwer:rollup-rt56ux6, r=JonathanBro…
800bb47 
…uwer

Rollup of 13 pull requests

Successful merges:

 - #146377 (Don't strip shebang in expr-ctxt `include!(…)`)
 - #149812 (Add const default for OnceCell and OnceLock)
 - #149882 (miri: add -Zbinary-dep-depinfo to dependency builds)
 - #150009 (Enable llvm-libunwind by default for Hexagon targets)
 - #150035 (fix docustring on fetch_or)
 - #150082 (tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case)
 - #150160 (Fix ICE (#149980) for invalid EII in statement position)
 - #150184 (mir_build: Use the same length type for `TestableCase::Slice` and `TestKind::Len`)
 - #150185 ([rustdoc] Add missing close tags in extern crate reexports)
 - #150191 (change non-canonical clone impl to {*self}, fix some doc comments)
 - #150203 (Drop the From derive macro from the v1 prelude)
 - #150208 (Update books)
 - #150210 (tests/debuginfo/function-arg-initialization.rs: Stop disabling SingleUseConsts MIR pass)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 21, 2025
@matthiaskrgr
Rollup merge of rust-lang#150185 - lambda:rustdoc-missing-close-tags-…
d107e95 
…reexport, r=GuillaumeGomez

[rustdoc] Add missing close tags in extern crate reexports

Fixes rust-lang#150176
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 21, 2025
Open
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 21, 2025
@JonathanBrouwer
Rollup merge of rust-lang#150185 - lambda:rustdoc-missing-close-tags-…
9cac665 
…reexport, r=GuillaumeGomez

[rustdoc] Add missing close tags in extern crate reexports

Fixes rust-lang#150176
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 21, 2025
Closed
bors added a commit that referenced this pull request Dec 21, 2025
@bors
Auto merge of #150228 - matthiaskrgr:rollup-ymp54q0, r=matthiaskrgr
542c040 
Rollup of 11 pull requests

Successful merges:

 - #146377 (Don't strip shebang in expr-ctxt `include!(…)`)
 - #149812 (Add const default for OnceCell and OnceLock)
 - #149882 (miri: add -Zbinary-dep-depinfo to dependency builds)
 - #150009 (Enable llvm-libunwind by default for Hexagon targets)
 - #150035 (fix docustring on fetch_or)
 - #150082 (tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case)
 - #150160 (Fix ICE (#149980) for invalid EII in statement position)
 - #150184 (mir_build: Use the same length type for `TestableCase::Slice` and `TestKind::Len`)
 - #150185 ([rustdoc] Add missing close tags in extern crate reexports)
 - #150191 (change non-canonical clone impl to {*self}, fix some doc comments)
 - #150203 (Drop the From derive macro from the v1 prelude)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cargo doc: pub extern crate causes rest of file to be formatted as code block

4 participants

@lambda @rustbot @GuillaumeGomez @bors