Skip to content

Conversation

@dianqk
Copy link
Member

@dianqk dianqk commented Dec 23, 2025

As an alternative to #150192.

r? ghost (for perf)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 23, 2025
@Kobzol
Copy link
Member

Kobzol commented Dec 23, 2025

@bors try @rust-timer queue

(I want to test if try builds work and this PR seems like a good fit for a perf. run :) )

@rust-timer

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Dec 23, 2025
[EXPERIMENT] New MIR Pass: SsaRangePropagation
@rust-bors

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 23, 2025
@rust-bors
Copy link

rust-bors bot commented Dec 23, 2025

☀️ Try build successful (CI)
Build commit: d9c5f75 (d9c5f757034b39605aac2eeef1b90a892b2c647d, parent: 99ff3fbb86658b427f5dd7daaae8db5626a63c26)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d9c5f75): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.3% [0.2%, 0.8%] 6
Regressions ❌
(secondary)
0.1% [0.0%, 0.3%] 8
Improvements ✅
(primary)
-0.4% [-0.9%, -0.2%] 7
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.1% [-0.9%, 0.8%] 13

Max RSS (memory usage)

Results (primary -0.9%, secondary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.0% [1.9%, 2.1%] 2
Regressions ❌
(secondary)
4.2% [0.9%, 5.5%] 7
Improvements ✅
(primary)
-3.8% [-5.4%, -2.2%] 2
Improvements ✅
(secondary)
-1.9% [-2.9%, -1.5%] 5
All ❌✅ (primary) -0.9% [-5.4%, 2.1%] 4

Cycles

Results (primary 1.8%, secondary -1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.8% [1.8%, 1.8%] 1
Regressions ❌
(secondary)
2.4% [2.3%, 2.6%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.2% [-6.2%, -1.2%] 5
All ❌✅ (primary) 1.8% [1.8%, 1.8%] 1

Binary size

Results (primary -0.0%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.3% [0.1%, 0.7%] 4
Regressions ❌
(secondary)
0.1% [0.1%, 0.2%] 2
Improvements ✅
(primary)
-0.1% [-0.8%, -0.0%] 17
Improvements ✅
(secondary)
-0.1% [-0.8%, -0.0%] 16
All ❌✅ (primary) -0.0% [-0.8%, 0.7%] 21

Bootstrap: 482.582s -> 484.115s (0.32%)
Artifact size: 390.35 MiB -> 390.71 MiB (0.09%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants