Skip to content

set score of ignored files to 10.0 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sandipagarwal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

set score of ignored files to 10.0 #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions git_pylint_commit_hook/commit_hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,17 +83,17 @@ def _is_python_file(filename):
r'^Your\ code\ has\ been\ rated\ at\ (\-?[0-9\.]+)/10')


def _parse_score(pylint_output):
def _parse_score(pylint_output, is_file_ignored=False):
"""Parse the score out of pylint's output as a float

If the score is not found, return 0.0.
If the score is not found, return 10.0 in case file is ignored else 0.0.

"""
for line in pylint_output.splitlines():
match = re.match(_SCORE_REGEXP, _futurize_str(line))
if match:
return float(match.group(1))
return 0.0
return 10.0 if is_file_ignored else 0.0


@contextlib.contextmanager
Expand Down Expand Up @@ -199,10 +199,18 @@ def check_repo(
sys.stdout.write("Running pylint on {} (file {}/{})..\t".format(
python_file, i, len(python_files)))
sys.stdout.flush()
is_file_ignored = False
try:
command = [pylint]
if pylint_params:
command += pylint_params.split()
params = pylint_params.split()
for param in params:
if 'ignore' in param:
ignore_pattern_text = param.split('=')[1]
ignore_pattern = re.compile(r'%s%s' % ('.' if ignore_pattern_text.startswith('*') else '', ignore_pattern_text))
if re.findall(ignore_pattern, python_file):
is_file_ignored = True
command += params
if '--rcfile' not in pylint_params:
command.append('--rcfile={}'.format(pylintrc))
else:
Expand All @@ -220,7 +228,7 @@ def check_repo(
sys.exit(1)

# Verify the score
score = _parse_score(out)
score = _parse_score(out, is_file_ignored)
if score >= float(limit):
status = 'PASSED'
else:
Expand Down