SNOW-2690900: isolate-server_session_keep_alive-condition #2722
+131
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-fpawlowski
force-pushed
the
SNOW-2690900-isolate-param-server_session_keep_alive-condition
branch
from
359149f to
fefa6c4
Compare
| ) | ||
| ) | ||
| else: | ||
| logger.info( |
Contributor
Author
There was a problem hiding this comment.
Important to make sure such communication at the INFO level is smth we want.
…ep_alive-condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new INFO log (we have 4 in basic flow, this 5th will happen only when param server_session_keep_alive is set to True).
Optimised conditions placement
possible decrease in time overhead for the whole session from 1% to 10% when firing 100 async queries.
100 queries + close:
server_session_keep_alive=False: 33.28s
server_session_keep_alive=True: 30.04s
→ True is faster by 3.25s (9.8%)
possible decrease in time overhead for only the connection.close() from 40% to 60% when firing 100 async queries.
100 queries, then CLOSE ONLY:
server_session_keep_alive=False: 0.504s
server_session_keep_alive=True: 0.214s
→ True is faster by 0.290s (57.5%)
Tested manually - no standard benchmarking.