Validate setting types at runtime #2016
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
matthewbastien
approved these changes
Dec 18, 2025
Because settings can be arbitrary JSON we should validate their type when reading them in. TypeScript provides a bit of a false sense of security here since at runtime they can be whatever the user wants, and then the extension falls over in wierd and wonderful ways. Add some basic type checking methods to make sure we're working with booleans, constrained strings/strings, or arrays of strings. Issue: swiftlang#2007
plemarquand
force-pushed
the
better-bad-settings-error-message
branch
from
d5ad5e1 to
94ce638
Compare
plemarquand
force-pushed
the
better-bad-settings-error-message
branch
2 times, most recently
from
49017c0 to
e923df5
Compare
plemarquand
force-pushed
the
better-bad-settings-error-message
branch
from
e923df5 to
d1d5a47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because settings can be arbitrary JSON we should validate their type when reading them in. TypeScript provides a bit of a false sense of security here since at runtime they can be whatever the user wants, and then the extension falls over in wierd and wonderful ways.
Add some basic type checking methods to make sure we're working with booleans, constrained strings/strings, or arrays of strings.
Issue: #2007
Tasks