Dedup segmented webvtt captions with the same id (fixes #1688) #1691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Issue: #1688
Description:
addCuenow checks if the cue's identifier has already been processed. Duplicate cues (by identifier) are ignored.Why duplicates occur:
Segmented WebVTT files can split a cue across segment boundaries. In such cases, the same cue may appear in multiple segments. Deduplicating by
idprevents the same cue from appearing twice on screen, without affecting cues that legitimately share content but have different IDs.Example — Segmented WebVTT:
Segment 1:
Segment 2
This would follow the approach used by
hls.jsto deduplicate cues across segmentsSee: video-dev/hls.js#4563
Ready?
Ready to be reviewed
Anything Else?
Before

After
