[css-forms-1] Use border-radius: 50% instead of 100% #13227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100% relies on the fixup rules to scale down to 50%, so maybe we should just say 50% directly since that's what we mean?
Contributor
|
I haven't prototyped base appearance radio inputs yet, but I don't imagine there will be any issues adding this to the UA stylesheet for base appearance when we get around to that |
josepharhar
approved these changes
Dec 16, 2025
lukewarlow
approved these changes
Dec 18, 2025
Member
lukewarlow
left a comment
lukewarlow
left a comment
There was a problem hiding this comment.
Tbh I'm not familiar with what is meant by "the fixup rule". But given 50% and 100% seem to do the same thing from a quick test. I'm happy with this.
Member
I have a chromium prototype patch for buttons that I'll try and fix up over christmas and then checkbox and radio are my next targets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
100% relies on the fixup rules to scale down to 50%, so maybe we should just say 50% directly since that's what we mean?